On 03/20/2015 07:59 AM, Jose Fonseca wrote:
Most cases seem harmless, though that might not always be the case. Maybe one day we can get gcc to complain about these and fix them throughout the code, but until then let's silence them. --- scons/gallium.py | 1 + 1 file changed, 1 insertion(+)diff --git a/scons/gallium.py b/scons/gallium.py index 52f1b8d..bf6d605 100755 --- a/scons/gallium.py +++ b/scons/gallium.py @@ -507,6 +507,7 @@ def generate(env): '/wd4018', # signed/unsigned mismatch '/wd4056', # overflow in floating-point constant arithmetic '/wd4244', # conversion from 'type1' to 'type2', possible loss of data + '/wd4267', # 'var' : conversion from 'size_t' to 'type', possible loss of data '/wd4305', # truncation from 'type1' to 'type2' '/wd4351', # new behavior: elements of array 'array' will be default initialized '/wd4756', # overflow in constant arithmetic
Would this silence cases of casting pointers to uint32, for example? I don't think we'd want to silence that kind of warning.
Anyway, the series looks good. Reviewed-by: Brian Paul <bri...@vmware.com> -Brian _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
