Patches 1, 2, 3, 4, 8, and 11 are Reviewed-by: Ilia Mirkin <imir...@alum.mit.edu>
The rest I sent comments on, although even if you address my feedback, I'm not sufficiently familiar to r-b at least some of them. If you do decide to play with UBO's, you can use idr's excellent random_ubo script to stress-test the various cases. Helped me a lot on getting doubles to actually work reliably. On Sat, Mar 21, 2015 at 5:49 AM, Timothy Arceri <t_arc...@yahoo.com.au> wrote: > This series adds most of the remaining glsl arrays of arrays support. Support > for uniform blocks is still missing, I've played around with this but don't > have anything working yet. > > What do you guys think about adding these changes without the uniform blocks > support? Adding these changes now I assume would make it easy for the nir > guys to start adding AoA support (if it doesn't exist already) and the intel > backend changes could start to be worked on. > > For anyone interested the main remaining changes to be made are in: > ./glsl/link_uniform_block_active_visitor.cpp > ./glsl/link_uniform_blocks.cpp > ./glsl/lower_ubo_reference.cpp > > For gallium drivers the glsl to tgsi conversion seems to handle everything > without changes so at least for the piglit tests I've written everything seem > to just work. > > There are no piglit regressions from these changes (tested on i965 driver) > and all the current arrays of arrays piglit test pass (tested with ilo > gallium driver using MESA_GL_VERSION_OVERRIDE=3.3COMPAT > MESA_GLSL_VERSION_OVERRIDE=150) besides the uniform block tests. There are > also some unreviewed interface linking tests relating to the last 4 patches > on the piglit list [1]. I also have some generated execution tests in my > piglit repo [2], I'm not sure if I've created these the best way and wish to > extend them further so these haven't been sent to the piglit list yet. > > [1] http://lists.freedesktop.org/archives/piglit/2015-March/015167.html > [2] > https://github.com/tarceri/Mesa_arrays_of_arrays_piglit/tree/execution_tests > _______________________________________________ > mesa-dev mailing list > mesa-dev@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/mesa-dev _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
