Re: [Mesa-dev] [PATCH] clover: Return 0 as storage size for local kernel args that are not set v2

[Francisco Jerez]

Tom Stellard <thomas.stell...@amd.com> writes:

> The storage size for local kernel args can be queried before the
> arguments are set by using the CL_KERNEL_LOCAL_MEM_SIZE param
> of clGetKernelWorkGroupInfo().
>
> The spec says that if local kernel arguments have not been specified,
> then we should assume their size is 0.
>
> v2:
>   - Implement using c++11 member initialization.
> ---
>  src/gallium/state_trackers/clover/core/kernel.hpp | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/gallium/state_trackers/clover/core/kernel.hpp 
> b/src/gallium/state_trackers/clover/core/kernel.hpp
> index bf5998d..d6432a4 100644
> --- a/src/gallium/state_trackers/clover/core/kernel.hpp
> +++ b/src/gallium/state_trackers/clover/core/kernel.hpp
> @@ -175,7 +175,7 @@ namespace clover {
>           virtual void unbind(exec_context &ctx);
>  
>        private:
> -         size_t _storage;
> +         size_t _storage = 0;
>        };
>  
>        class constant_argument : public argument {
> -- 
> 2.0.4

Reviewed-by: Francisco Jerez <curroje...@riseup.net>

signature.asc
Description: PGP signature

_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev