Kenneth Graunke <kenn...@whitecape.org> writes: > On Monday, March 30, 2015 11:44:19 AM Eric Anholt wrote: >> Brian Paul <bri...@vmware.com> writes: >> >> > On 03/30/2015 10:49 AM, Eric Anholt wrote: >> >> NIR uses these enums/#defines in nir_variables and associated intrinsics, >> >> but I want to be able to use them from TGSI->NIR and NIR->TGSI. >> >> Otherwise, we had to pull in all of mtypes.h. >> >> >> >> This doesn't cover all of the enums we might want from a shared compiler >> >> core (like varying slots or vert attribs), but it at least covers what I >> >> need at the moment (system values and interp qualifiers). >> >> >> >> v2: Move to src/glsl since util/ is really vague. Include in Makefile.am >> >> list. Use plain bitshifts and stdint types instead of undefined >> >> BITFIELD64_BIT. >> >> --- >> >> src/glsl/Makefile.am | 1 + >> >> src/glsl/pipeline.h | 170 >> >> +++++++++++++++++++++++++++++++++++++++++++++++++ >> >> src/mesa/main/mtypes.h | 142 +---------------------------------------- >> >> 3 files changed, 172 insertions(+), 141 deletions(-) >> >> create mode 100644 src/glsl/pipeline.h >> >> >> > >> > pipeline.h seems a bit broadly named for the current contents. Do you >> > expect to add many other things besides shader register names and interp >> > modes? >> >> The things mentioned in the commit message, for sure. I could also >> imagine enums like PIPE_FUNC_* too, as we may want to have NIR-level >> programmable blending lowering or shadow compares, for example. >> >> > Though, I don't have better filename idea right now. >> >> Exactly. > > Maybe shader_enums.h? Regardless, > Reviewed-by: Kenneth Graunke <kenn...@whitecape.org>
Would that make others happy?
signature.asc
Description: PGP signature
_______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
