On 04/15/2015 10:56 AM, Emil Velikov wrote: > On 15 April 2015 at 18:33, Matt Turner <matts...@gmail.com> wrote: >> On Wed, Apr 15, 2015 at 7:08 AM, Emil Velikov <emil.l.veli...@gmail.com> >> wrote: >>> Rather than forcing everyone to provide their own definition of the symbol >>> provide a common weak one, which anyone can override if needed. >>> >>> This resolved the build of the standalone pipe-drivers, as it provides a >>> default symbol which was missing previously. >>> >>> Cc: Rob Clark <robcl...@freedesktop.org> >>> Signed-off-by: Emil Velikov <emil.l.veli...@gmail.com> >>> --- >>> src/Makefile.am | 3 ++- >>> src/glsl/SConscript | 2 ++ >>> src/mesa/Android.libmesa_glsl_utils.mk | 6 ++++-- >>> src/mesa/program/weak_errors.c | 30 ++++++++++++++++++++++++++++++ >> >> Is program/ really the right place for this? (maybe main/ instead?) > Hmm main/ might be better indeed. If there are any recommendations > about the name I'll gladly take it :)
So... who is going to use this other than src/glsl/main.cpp and src/glsl/tests? It seems like you could just put the (non-weak) symbol in a common file that only those things link. Is the goal just code sharing, or is the goal partitioning src/glsl from src/mesa? The former probably isn't worth the effort, and the latter should have a more systematic approach... and I could get behind that. > Jose/Brian > > From a quick look I cannot find a suitable alternative for > __attribute__((weak)) for MSVC. Would you know any of the top of your > head or should I just wrap the attribute in ifndef _MSC_VER and leave > the rest ? If I drop the weak_errors.c hunk from the SCons here, and > replace tests/common.c with it things should just work. > > > Thanks > Emil > _______________________________________________ > mesa-dev mailing list > mesa-dev@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/mesa-dev > _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
