When there is a colormask active that does not cover all of the format, enabling reading in the destination like with a combining blend operation. This fixes fbo-blending-formats on a3xx.
Signed-off-by: Ilia Mirkin <[email protected]> --- Experimentally, RGB10_A2 does not need this... weird, but wtvr. src/gallium/drivers/freedreno/a3xx/fd3_emit.c | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/src/gallium/drivers/freedreno/a3xx/fd3_emit.c b/src/gallium/drivers/freedreno/a3xx/fd3_emit.c index af08696..07cc226 100644 --- a/src/gallium/drivers/freedreno/a3xx/fd3_emit.c +++ b/src/gallium/drivers/freedreno/a3xx/fd3_emit.c @@ -704,6 +704,8 @@ fd3_emit_state(struct fd_context *ctx, struct fd_ringbuffer *ring, for (i = 0; i < ARRAY_SIZE(blend->rb_mrt); i++) { enum pipe_format format = pipe_surface_format(ctx->framebuffer.cbufs[i]); + const struct util_format_description *desc = + util_format_description(format); bool is_float = util_format_is_float(format); bool is_int = util_format_is_pure_integer(format); bool has_alpha = util_format_has_alpha(format); @@ -726,6 +728,18 @@ fd3_emit_state(struct fd_context *ctx, struct fd_ringbuffer *ring, control &= ~A3XX_RB_MRT_CONTROL_BLEND2; } + if (format && util_format_get_component_bits( + format, UTIL_FORMAT_COLORSPACE_RGB, 0) < 8) { + const struct pipe_rt_blend_state *rt; + if (ctx->blend->independent_blend_enable) + rt = &ctx->blend->rt[i]; + else + rt = &ctx->blend->rt[0]; + + if (!util_format_colormask_full(desc, rt->colormask)) + control |= A3XX_RB_MRT_CONTROL_READ_DEST_ENABLE; + } + OUT_PKT0(ring, REG_A3XX_RB_MRT_CONTROL(i), 1); OUT_RING(ring, control); -- 2.0.5 _______________________________________________ mesa-dev mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/mesa-dev
