On 05/07/2015 07:30 AM, Jason Ekstrand wrote: > On Wed, May 6, 2015 at 7:29 PM, Matt Turner <[email protected]> wrote: >> On Wed, May 6, 2015 at 7:09 PM, Ian Romanick <[email protected]> wrote: >>> From: Ian Romanick <[email protected]> >>> >>> It's a weird thing that provides some values related to 2**x. It's also >>> already handled by a case in the switch. >>> >>> Signed-off-by: Ian Romanick <[email protected]> >> >> The series is >> >> Reviewed-by: Matt Turner <[email protected]> > > I was going to complain about you making my SPIR-V -> NIR translator > harder to write. But, based on the discussion by Ken and Ilia on IRC, > it looks like basically no one's hardware does a base-e log. I'll > just lower on-the-fly. I guess maybe we could do it with pow(x, e) > but meh. If you'd like, the series is
Right. We currently unconditionally lower exp(x) to exp2(x * M_LOG2E) in the GLSL IR lowering code. I believe we picked that lowering because some older architectures lack a pow instruction. It may be worth trying the other way to see if we get better code. > Acked-by: Jason Ekstrand <[email protected]> > > I can't say I read it enough to call it a review but I glanced through > it and it seems ok. > --Jason > _______________________________________________ mesa-dev mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/mesa-dev
