On Sat, May 16, 2015 at 8:37 AM, Jason Ekstrand <[email protected]> wrote: > On Fri, May 15, 2015 at 2:02 PM, Matt Turner <[email protected]> wrote: >> 32-bit x 32-bit integer multiplication requires multiple instructions >> until Broadwell. This patch just lets us treat the MUL instruction in >> the FS backend like it operates on Broadwell, and after optimizations >> we lower it into a sequence of instructions on older platforms. > > Any reason why you chose to re-use the MUL instruction with D types > rather than making a logical IMUL instruction? I think I have a minor > preference for IMUL but I also understand that it can be a pain to > plumb through.
Yes, basically I'm just changing the integer multiply IR from pre-Broadwell to Broadwell semantics, and the lowering pass sorts out the pre-Broadwell differences. Since you still have to have MUL, this seems cleaner than adding an additional virtual operation (which wouldn't be necessary on Broadwell). _______________________________________________ mesa-dev mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/mesa-dev
