On 26/05/15 19:11, Brian Paul wrote: > On 05/26/2015 02:05 PM, Emil Velikov wrote: >> On 25/05/15 14:41, Brian Paul wrote: >>> If the glPushAttrib() mask value was zero we didn't actually push >>> anything onto the attribute stack. A subsequent glPopAttrib() call >>> would generate a GL_STACK_UNDERFLOW error. Now push a dummy attribute >>> in that case to prevent the error. >>> >>> Mesa now matches nvidia's behavior. >> If you feel that these cause significant headaches for game/app >> developers feel free to throw in the stable tag on the series. > > I only found this during the course of debugging an app that used > glPush/PopAttrib and I was trimming down the attrib mask. I hit 0 at > one point and discovered the error/bug then. I'm not aware of any apps > that hit this. > Ack. It all sounded like a case where devs might be "a bit" annoyed in the inconsistency between GL implementations.
> R-b? > My knowledge in the area is quite not up-to par to review this. Sorry :-\ -Emil _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
