On Monday, June 01, 2015 03:14:24 PM Abdiel Janulgue wrote: > v2: Simplify HW binding table bit definitions and magic constants (Topi) > v3: Add Broadwell support. > > Cc: kristian.h.kristen...@intel.com > Cc: topi.pohjolai...@intel.com > Cc: kenn...@whitecape.org > Reviewed-by: Topi Pohjolainen <topi.pohjolai...@intel.com> > Signed-off-by: Abdiel Janulgue <abdiel.janul...@linux.intel.com> > --- > src/mesa/drivers/dri/i965/brw_defines.h | 30 ++++++++++++++++++++++++++++++ > src/mesa/drivers/dri/i965/intel_reg.h | 3 +++ > 2 files changed, 33 insertions(+)
Hi Abdiel, I've finished reviewing this round of HW binding table patches. Despite the number of comments I had, I think most of them should be pretty straightforward changes. I actually think that these patches look quite reasonable, and I expect we can land them soon. I think you've demonstrated that gather constants are a big win, and we'll need hardware binding tables to make that happen. So it makes sense to land this infrastructure in preparation for those. I appreciate how unintrusive these changes are. You've done a nice job of making the transition simple, and the patch series was easy to read through. Thanks for your hard work in this area! I'll try to look at the gather constant patches soon as well. --Ken
signature.asc
Description: This is a digitally signed message part.
_______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
