On Tuesday, July 21, 2015 03:19:25 PM Dave Airlie wrote: > From: Dave Airlie <airl...@redhat.com> > > This fleshes out the APIs, using the program resource > APIs where they should match. > > It also sets the default values to valid subroutines. > > Signed-off-by: Dave Airlie <airl...@redhat.com> > --- > src/mesa/main/shaderapi.c | 450 > +++++++++++++++++++++++++++++++++++++++++++++- > src/mesa/main/shaderapi.h | 3 + > 2 files changed, 450 insertions(+), 3 deletions(-)
So, one question I have...according to the spec... "Subroutine uniform variables are similar to uniform variables, except they are context state rather than program state. Having subroutine uniforms be context state allows them to have different values if the program is used in multiple contexts simultaneously. There is a set of subroutine uniforms for each shader stage." but it looks like we're storing them in the shader, rather than per-context. Bug? Or am I missing something? At this point I'm just inclined to give everything I haven't reviewed an Acked-by: Kenneth Graunke <kenn...@whitecape.org> I don't think anybody wants to spend much more time on this, and it'd be nice to check off the box and move on.
signature.asc
Description: This is a digitally signed message part.
_______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev