On Mon, Nov 9, 2015 at 8:39 AM, Rob Clark <robdcl...@gmail.com> wrote: > On Mon, Nov 9, 2015 at 8:30 AM, Emil Velikov <emil.l.veli...@gmail.com> wrote: >> On 30 October 2015 at 17:57, Emil Velikov <emil.l.veli...@gmail.com> wrote: >>> On 19 October 2015 at 18:41, Emil Velikov <emil.l.veli...@gmail.com> wrote: >>>> On 19 October 2015 at 17:07, Brian Paul <bri...@vmware.com> wrote: >>> >>>>> >>>>> I'm not too familiar with this code or these changes but I'm wondering how >>>>> much of chance there is of this breaking any driver/target builds. >>>>> >>>>> For example, is there a chance of breaking the VMware driver or Windows >>>>> builds? I don't have time to test this series here ATM, but I guess I >>>>> could >>>>> later this week. >>>>> >>>> Afaics the Windows builds are unaffected. On the svga/vmwgfx front, >>>> (of the top of my head) I'd say - 1-2% chance that things have >>>> regressed (due to git rebase fallouts, as spotted with the missing >>>> winsys->destroy). >>>> >>>> But in all means please do give them a bash. These can wait a week or >>>> so (but hopefully less than a month). >>>> >>> Hi Brian, >>> I suspect you did not have the time to test the series, have you ? As >>> we've got some patches that conflict with this, I'm wondering if I >>> should respin things (+ drop the sw_winsys rework as mentioned) or if >>> I should chill for another week or so. >>> >>> >>> Rob, >>> Considering how unhappy you were with the with the current state of >>> things (bth neither was I, but you can see why I haven't bothered >>> earlier), can you please take a look and/or test. You will still need >>> the "WIP: gallium: introduce load_pipe_screen()" on top, for Android. >>> >>> The lot can be found in branch pipe-loader-redux at >>> https://github.com/evelikov/Mesa/ >>> >> Guys anyone ? >> >> I'm not asking for anyone to review the patches, although a ACK/NACK >> and/or test on your platforms will be greatly appreciated. > > yeah, I'm interested in this patchset.. sorry, been busy on other > things so didn't yet have a chance to rebase my android build > (although I am also interested in moving drm_gralloc into mesa tree).. >
btw, not sure if I'll really be getting time to play w/ android builds before next release branch.. but imho this patchset is moving in the right direction, so if it doesn't break any normal use cases, I'd say to go ahead and push w/ my ack-by. If we at least get it in before branch point, and some small tweaks are needed later for android build, we can always cherry-pick those for the release branch BR, -R _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
