----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2719/#review3099 -----------------------------------------------------------
The patch looks good to me overall, but one issue is that you're building a HashMap with protobuf objects (OfferID) as the key in the resource offer handler. According to http://code.google.com/p/protobuf/issues/detail?id=288, hashCode() can be inconsistent for protobuf objects, and I remember running into a problem with it before. It might be better to just call toString on the IDs or even have an array of ArrayLists in the same order as the offers. - Matei On 2011-11-04 00:17:22, Charles Reiss wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/2719/ > ----------------------------------------------------------- > > (Updated 2011-11-04 00:17:22) > > > Review request for mesos. > > > Summary > ------- > > How offers are presented in the Java scheduler API and how scheduler > registration parameters are passed changed recently and the sample > hadoop-0.20.2 framework was not updated. This patch updates the Hadoop > framework so it compiles. > > An additional change will be needed to update the supplied .diff file (that > will not be a human-readable patch). > > > This addresses bug MESOS-13. > https://issues.apache.org/jira/browse/MESOS-13 > > > Diffs > ----- > > > frameworks/hadoop-0.20.2/src/contrib/mesos/src/java/org/apache/hadoop/mapred/FrameworkScheduler.java > f2d5772 > > frameworks/hadoop-0.20.2/src/contrib/mesos/src/java/org/apache/hadoop/mapred/MesosScheduler.java > e2c1195 > > Diff: https://reviews.apache.org/r/2719/diff > > > Testing > ------- > > > Thanks, > > Charles > >
