----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2685/#review3212 -----------------------------------------------------------
Ship it! src/tests/utils.hpp <https://reviews.apache.org/r/2685/#comment7133> Let's do s/_filter/object just so we don't introduce this underscore convention in the code base. If you have a better name than 'object' (e.g., receiver?), please suggest it. Also, if you can think of a way to make triggering on messages even more abstracted (i.e., no need for MockFilter object and process::filter) that would be splendid! - Benjamin On 2011-11-02 23:45:46, Charles Reiss wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/2685/ > ----------------------------------------------------------- > > (Updated 2011-11-02 23:45:46) > > > Review request for mesos. > > > Summary > ------- > > See description of bugs in MESOS-59. > > > This addresses bug MESOS-59. > https://issues.apache.org/jira/browse/MESOS-59 > > > Diffs > ----- > > src/tests/utils.hpp 02772f7 > > Diff: https://reviews.apache.org/r/2685/diff > > > Testing > ------- > > > Thanks, > > Charles > >
