> On 2011-11-14 22:24:48, Benjamin Hindman wrote: > > src/tests/utils.hpp, line 313 > > <https://reviews.apache.org/r/2669/diff/3/?file=58102#file58102line313> > > > > Kill this now (unused code).
Done. > On 2011-11-14 22:24:48, Benjamin Hindman wrote: > > src/tests/utils.hpp, line 247 > > <https://reviews.apache.org/r/2669/diff/3/?file=58102#file58102line247> > > > > Put '{' on newline and add a small comment explaining why we mock out > > 'resourcesChanged' (e.g., to be able to trigger for testing purposes). Done. (Comment added next to MOCK_METHOD...().) - Charles ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2669/#review3239 ----------------------------------------------------------- On 2011-11-21 03:23:26, Charles Reiss wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/2669/ > ----------------------------------------------------------- > > (Updated 2011-11-21 03:23:26) > > > Review request for mesos. > > > Summary > ------- > > This calls Executor::addTask to accumulate the usage of queued tasks before > calling resourcesChanged() to ensure the executor has enough resources to run > those queued tasks. > > > This addresses bug MESOS-56. > https://issues.apache.org/jira/browse/MESOS-56 > > > Diffs > ----- > > src/slave/slave.cpp de5716c > src/tests/master_tests.cpp 2438114 > src/tests/utils.hpp 02772f7 > > Diff: https://reviews.apache.org/r/2669/diff > > > Testing > ------- > > Modification to MasterTest included. > > > Thanks, > > Charles > >
