[
https://issues.apache.org/jira/browse/MESOS-59?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13153988#comment-13153988
]
[email protected] commented on MESOS-59:
----------------------------------------------------
bq. On 2011-11-14 19:29:50, Benjamin Hindman wrote:
bq. > src/tests/utils.hpp, line 185
bq. > <https://reviews.apache.org/r/2685/diff/1/?file=55928#file55928line185>
bq. >
bq. > Let's do s/_filter/object just so we don't introduce this underscore
convention in the code base. If you have a better name than 'object' (e.g.,
receiver?), please suggest it. Also, if you can think of a way to make
triggering on messages even more abstracted (i.e., no need for MockFilter
object and process::filter) that would be splendid!
bq.
bq. Charles Reiss wrote:
bq. I choose the name 'mock_filter'.
bq.
bq. (Er, and apologies for the empty comment spam here...)
bq.
bq. Benjamin Hindman wrote:
bq. No worries, but let's make it mockFilter. ;)
Done. (6 days ago, but I guess just posting an updated diff doesn't make it
clear.)
- Charles
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2685/#review3212
-----------------------------------------------------------
On 2011-11-14 23:13:38, Charles Reiss wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/2685/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-11-14 23:13:38)
bq.
bq.
bq. Review request for mesos.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. See description of bugs in MESOS-59.
bq.
bq.
bq. This addresses bug MESOS-59.
bq. https://issues.apache.org/jira/browse/MESOS-59
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. src/tests/utils.hpp 02772f7
bq.
bq. Diff: https://reviews.apache.org/r/2685/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq.
bq. Thanks,
bq.
bq. Charles
bq.
bq.
> Test macros in tests/utils.hpp aren't robust
> --------------------------------------------
>
> Key: MESOS-59
> URL: https://issues.apache.org/jira/browse/MESOS-59
> Project: Mesos
> Issue Type: Bug
> Components: test
> Reporter: Charles Reiss
> Assignee: Charles Reiss
> Priority: Trivial
>
> The EXPECT_MSG macro in tests/utils.hpp won't work if the MockFilter object
> is called anythig but filter (because it's the method and macro argument
> name).
> The WAIT_UNTIL macro in tests/utils.hpp doesn't put parens around its
> argument so something like WAIT_UNTIL(&trigger) will always return
> immediately instead of causing a compilation error.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
