> On 2011-11-14 20:24:47, Benjamin Hindman wrote: > > include/mesos/mesos.proto, line 158 > > <https://reviews.apache.org/r/2770/diff/1/?file=56821#file56821line158> > > > > Let's change this to webui_hostname too please.
Done. > On 2011-11-14 20:24:47, Benjamin Hindman wrote: > > src/master/http.cpp, line 114 > > <https://reviews.apache.org/r/2770/diff/1/?file=56822#file56822line114> > > > > s/web_ui_url/webui_hostname and swap the order please (and don't forget > > to propagate the changes). Done. > On 2011-11-14 20:24:47, Benjamin Hindman wrote: > > src/slave/slave.cpp, line 273 > > <https://reviews.apache.org/r/2770/diff/1/?file=56823#file56823line273> > > > > s/public_hostname/webui_hostname Done. - Sumedh ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2770/#review3219 ----------------------------------------------------------- On 2011-11-15 02:29:18, Sumedh Sawant wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/2770/ > ----------------------------------------------------------- > > (Updated 2011-11-15 02:29:18) > > > Review request for mesos, Benjamin Hindman and Andy Konwinski. > > > Summary > ------- > > Added webUI field to the SlaveInfo message so that a master can correctly > display hyperlinks to slaves in its webUI. > > > This addresses bug MESOS-33. > https://issues.apache.org/jira/browse/MESOS-33 > > > Diffs > ----- > > include/mesos/mesos.proto 33248ec > src/master/http.cpp 47caf48 > src/slave/slave.cpp de5716c > src/webui/master/index.tpl 16e3446 > > Diff: https://reviews.apache.org/r/2770/diff > > > Testing > ------- > > > Thanks, > > Sumedh > >
