----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2763/#review3467 -----------------------------------------------------------
Ship it! Great! This will be super cool to see in use! src/master/constants.hpp <https://reviews.apache.org/r/2763/#comment7729> As good practice, feel free to add your name next to the TODO. As in TODO(Thomas Marshall) or a shorthand that uniquely identifies you (I do TODO(benh)). This doesn't mean you are required to ultimately do the TODO, but it enables someone else to contact you if they want more context than what ended up being written in the TODO. Obviously your TODOs here are pretty self explanatory, but it's a good practice to get into. And one final nit: comments, including those in the TODO, should be sentences. src/master/http.cpp <https://reviews.apache.org/r/2763/#comment7730> s/Task/const Task& src/master/http.cpp <https://reviews.apache.org/r/2763/#comment7731> s/Framework/const Framework& src/master/master.hpp <https://reviews.apache.org/r/2763/#comment7732> Just do completedTasks.push_back(*task); src/master/master.hpp <https://reviews.apache.org/r/2763/#comment7734> Space after if. src/master/master.cpp <https://reviews.apache.org/r/2763/#comment7733> And put a newline after framework->unregisteredTime = elapsedTime(); src/webui/master/index.tpl <https://reviews.apache.org/r/2763/#comment7735> :) - Benjamin On 2011-11-15 00:59:14, Thomas Marshall wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/2763/ > ----------------------------------------------------------- > > (Updated 2011-11-15 00:59:14) > > > Review request for mesos and Andy Konwinski. > > > Summary > ------- > > Frameworks are no longer deleted when they are done executing; they are saved > in a list in the master, which is then displayed on the webui. Tasks are > similarly stored in their framework. > > > This addresses bug MESOS-8. > https://issues.apache.org/jira/browse/MESOS-8 > > > Diffs > ----- > > src/webui/master/index.tpl 16e3446 > src/master/constants.hpp db82177 > src/master/http.cpp 47caf48 > src/master/master.hpp fdacf36 > src/master/master.cpp b6cfde7 > src/webui/master/framework.tpl 0f41349 > > Diff: https://reviews.apache.org/r/2763/diff > > > Testing > ------- > > > Thanks, > > Thomas > >
