[
https://issues.apache.org/jira/browse/MESOS-8?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13155710#comment-13155710
]
[email protected] commented on MESOS-8:
---------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2763/#review3467
-----------------------------------------------------------
Ship it!
Great! This will be super cool to see in use!
src/master/constants.hpp
<https://reviews.apache.org/r/2763/#comment7729>
As good practice, feel free to add your name next to the TODO. As in
TODO(Thomas Marshall) or a shorthand that uniquely identifies you (I do
TODO(benh)). This doesn't mean you are required to ultimately do the TODO, but
it enables someone else to contact you if they want more context than what
ended up being written in the TODO. Obviously your TODOs here are pretty self
explanatory, but it's a good practice to get into. And one final nit: comments,
including those in the TODO, should be sentences.
src/master/http.cpp
<https://reviews.apache.org/r/2763/#comment7730>
s/Task/const Task&
src/master/http.cpp
<https://reviews.apache.org/r/2763/#comment7731>
s/Framework/const Framework&
src/master/master.hpp
<https://reviews.apache.org/r/2763/#comment7732>
Just do completedTasks.push_back(*task);
src/master/master.hpp
<https://reviews.apache.org/r/2763/#comment7734>
Space after if.
src/master/master.cpp
<https://reviews.apache.org/r/2763/#comment7733>
And put a newline after framework->unregisteredTime = elapsedTime();
src/webui/master/index.tpl
<https://reviews.apache.org/r/2763/#comment7735>
:)
- Benjamin
On 2011-11-15 00:59:14, Thomas Marshall wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/2763/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-11-15 00:59:14)
bq.
bq.
bq. Review request for mesos and Andy Konwinski.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Frameworks are no longer deleted when they are done executing; they are
saved in a list in the master, which is then displayed on the webui. Tasks are
similarly stored in their framework.
bq.
bq.
bq. This addresses bug MESOS-8.
bq. https://issues.apache.org/jira/browse/MESOS-8
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. src/webui/master/index.tpl 16e3446
bq. src/master/constants.hpp db82177
bq. src/master/http.cpp 47caf48
bq. src/master/master.hpp fdacf36
bq. src/master/master.cpp b6cfde7
bq. src/webui/master/framework.tpl 0f41349
bq.
bq. Diff: https://reviews.apache.org/r/2763/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq.
bq. Thanks,
bq.
bq. Thomas
bq.
bq.
> Maintain a history of executed frameworks/tasks and show it on the web UI
> -------------------------------------------------------------------------
>
> Key: MESOS-8
> URL: https://issues.apache.org/jira/browse/MESOS-8
> Project: Mesos
> Issue Type: Improvement
> Reporter: Matei Zaharia
> Assignee: Thomas Marshall
>
> This is kind of a big task but ultimately important for cluster management.
> See https://github.com/mesos/mesos/issues#issue/39 for previous discussion on
> GitHub.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
