[ 
https://issues.apache.org/jira/browse/MESOS-56?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13155725#comment-13155725
 ] 

[email protected] commented on MESOS-56:
----------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2669/#review3468
-----------------------------------------------------------

Ship it!


We're going to commit this but just kill the orphaned line.


src/tests/utils.hpp
<https://reviews.apache.org/r/2669/#comment7736>

    I think this is an orphaned line ...


- Benjamin


On 2011-11-21 03:23:26, Charles Reiss wrote:
bq.  
bq.  -----------------------------------------------------------
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/2669/
bq.  -----------------------------------------------------------
bq.  
bq.  (Updated 2011-11-21 03:23:26)
bq.  
bq.  
bq.  Review request for mesos.
bq.  
bq.  
bq.  Summary
bq.  -------
bq.  
bq.  This calls Executor::addTask to accumulate the usage of queued tasks 
before calling resourcesChanged() to ensure the executor has enough resources 
to run those queued tasks.
bq.  
bq.  
bq.  This addresses bug MESOS-56.
bq.      https://issues.apache.org/jira/browse/MESOS-56
bq.  
bq.  
bq.  Diffs
bq.  -----
bq.  
bq.    src/slave/slave.cpp de5716c 
bq.    src/tests/master_tests.cpp 2438114 
bq.    src/tests/utils.hpp 02772f7 
bq.  
bq.  Diff: https://reviews.apache.org/r/2669/diff
bq.  
bq.  
bq.  Testing
bq.  -------
bq.  
bq.  Modification to MasterTest included.
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Charles
bq.  
bq.


                
> Resources of tasks queued during executor launch not always accounted for
> -------------------------------------------------------------------------
>
>                 Key: MESOS-56
>                 URL: https://issues.apache.org/jira/browse/MESOS-56
>             Project: Mesos
>          Issue Type: Bug
>          Components: isolation, slave
>            Reporter: Charles Reiss
>            Assignee: Charles Reiss
>
> When initially launching an executor, the slave queues the tasks sent to the 
> executor until the executor registers itself with the slave. When this 
> happens, the slave calls resourcesChanged() on the isolation module, but 
> before it adds the usage of the queued tasks.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to