> On 2011-11-21 23:03:35, Andy Konwinski wrote:
> > I'm about to commit this. Thanks Charles!
>
> Benjamin Hindman wrote:
> We should revert this commit and instead apply the following:
>
>
> diff --git a/src/python/native/mesos_executor_driver_impl.cpp
> b/src/python/native/mesos_executor_driver_impl.cpp
> index ed4aaa5..9e10873 100644
> --- a/src/python/native/mesos_executor_driver_impl.cpp
> +++ b/src/python/native/mesos_executor_driver_impl.cpp
> @@ -231,9 +231,9 @@ PyObject*
> MesosExecutorDriverImpl_stop(MesosExecutorDriverImpl* self,
> return NULL;
> }
>
> - bool failover = false;
> + bool failover = false; // Should match default in mesos.py.
>
> - if (!PyArg_ParseTuple(args, "b", &failover)) {
> + if (!PyArg_ParseTuple(args, "|b", &failover)) {
> return NULL;
> }
>
>
> diff --git a/src/python/native/mesos_scheduler_driver_impl.cpp
> b/src/python/native/mesos_scheduler_driver_impl.cpp
> index 4bde768..683ad04 100644
> --- a/src/python/native/mesos_scheduler_driver_impl.cpp
> +++ b/src/python/native/mesos_scheduler_driver_impl.cpp
> @@ -275,7 +275,7 @@ PyObject*
> MesosSchedulerDriverImpl_stop(MesosSchedulerDriverImpl* self,
>
> bool failover = false;
>
> - if (!PyArg_ParseTuple(args, "b", &failover)) {
> + if (!PyArg_ParseTuple(args, "|b", &failover)) {
> return NULL;
> }
>
>
Actually, both should have the comment:
diff --git a/src/python/native/mesos_scheduler_driver_impl.cpp
b/src/python/native/mesos_scheduler_driver_impl.cpp
index 4bde768..683ad04 100644
--- a/src/python/native/mesos_scheduler_driver_impl.cpp
+++ b/src/python/native/mesos_scheduler_driver_impl.cpp
@@ -275,7 +275,7 @@ PyObject*
MesosSchedulerDriverImpl_stop(MesosSchedulerDriverImpl* self,
bool failover = false; // Should match default in mesos.py.
- if (!PyArg_ParseTuple(args, "b", &failover)) {
+ if (!PyArg_ParseTuple(args, "|b", &failover)) {
return NULL;
}
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2815/#review3410
-----------------------------------------------------------
On 2011-11-12 08:28:53, Charles Reiss wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/2815/
> -----------------------------------------------------------
>
> (Updated 2011-11-12 08:28:53)
>
>
> Review request for mesos.
>
>
> Summary
> -------
>
> Fixes MESOS-78.
>
>
> This addresses bug MESOS-78.
> https://issues.apache.org/jira/browse/MESOS-78
>
>
> Diffs
> -----
>
> src/examples/python/test_framework.py 0e4b14c
>
> Diff: https://reviews.apache.org/r/2815/diff
>
>
> Testing
> -------
>
> Checked output of tests/external/SampleFrameworks/PythonFramework.sh
>
>
> Thanks,
>
> Charles
>
>
