> On 2011-12-15 00:30:09, Benjamin Hindman wrote: > > src/java/jni/convert.cpp, line 49 > > <https://reviews.apache.org/r/3083/diff/1/?file=63411#file63411line49> > > > > I see this got added, but it's not used? I know in a previous review > > (internal) I had suggested this ... did the rest of the code that was part > > of it get dropped? If so, we should drop this too.
hmm..looks like a bad diff merge...let me get the correct diff - Vinod ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3083/#review3917 ----------------------------------------------------------- On 2011-12-09 02:41:32, Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/3083/ > ----------------------------------------------------------- > > (Updated 2011-12-09 02:41:32) > > > Review request for mesos, Benjamin Hindman and John Sirois. > > > Summary > ------- > > New Scheduler callbacks for master info (ip and port) > > --> registered() callback now includes maste info > --> new re-registered() callback is called when a new master is elected > --> new masterLost() callback is called when mesos core doesnt detect an > active master (e.g: during election) > > > This addresses bug MESOS-86. > https://issues.apache.org/jira/browse/MESOS-86 > > > Diffs > ----- > > include/mesos/scheduler.hpp 93dda98 > src/examples/cpp_test_framework.cpp ab02805 > src/examples/java/TestExceptionFramework.java ba39757 > src/examples/java/TestFramework.java e1b6032 > src/examples/java/TestMultipleExecutorsFramework.java a49ecbb > src/examples/long_lived_framework.cpp 4003e47 > src/examples/memhog.cpp 339d238 > src/examples/python/test_framework.py e6893cf > src/examples/scheduled_memhog.cpp 5d01aef > src/java/jni/convert.cpp 04a25dd > src/java/jni/org_apache_mesos_MesosSchedulerDriver.cpp 8704663 > src/java/src/org/apache/mesos/Scheduler.java 63a06fe > src/master/master.cpp ede831e > src/messages/messages.proto a9cbcdc > src/python/native/proxy_scheduler.hpp a348cbb > src/python/native/proxy_scheduler.cpp 934820a > src/python/src/mesos.py 5fc60e2 > src/sched/sched.cpp 7f4e980 > src/tests/exception_tests.cpp 62f4fb6 > src/tests/fault_tolerance_tests.cpp ebb7709 > src/tests/master_tests.cpp a1f5007 > src/tests/resource_offers_tests.cpp 8e1061e > src/tests/utils.hpp 65ce4df > > Diff: https://reviews.apache.org/r/3083/diff > > > Testing > ------- > > ./bin/tests/all-tests > > > Thanks, > > Vinod > >
