----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3416/#review4276 -----------------------------------------------------------
Ship it! src/common/attributes.hpp <https://reviews.apache.org/r/3416/#comment9651> why do u need a clear() here and not in the copy constructor? src/common/values.cpp <https://reviews.apache.org/r/3416/#comment9653> s/doesn't/donot/ src/common/values.cpp <https://reviews.apache.org/r/3416/#comment9657> s/ranges/range - Vinod On 2012-01-06 19:30:59, Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/3416/ > ----------------------------------------------------------- > > (Updated 2012-01-06 19:30:59) > > > Review request for mesos, Andy Konwinski, Matei Zaharia, John Sirois, and > Vinod Kone. > > > Summary > ------- > > This is the remaining internal Twitter code that is getting pushed out so the > repositories are in sync. After this all development will be done via Apache. > > **** I expect that there will be some conflicts and I'll be needing to pull > certain things from the Apache repo to make things sane ... more eyes the > better! **** > > > This addresses bug MESOS-113. > https://issues.apache.org/jira/browse/MESOS-113 > > > Diffs > ----- > > include/mesos/executor.hpp d883f1a > include/mesos/mesos.proto 77a9067 > src/Makefile.in 516f128 > src/common/attributes.hpp PRE-CREATION > src/common/attributes.cpp PRE-CREATION > src/common/json.hpp fc6b45f > src/common/lambda.hpp 0fc81c5 > src/common/multihashmap.hpp 43c535d > src/common/process_utils.hpp 8e55d76 > src/common/resources.hpp 58c91f4 > Makefile.in e8dec7a > src/common/resources.cpp 5afd134 > src/common/seconds.hpp ade6fc9 > src/common/strings.hpp 09a367d > src/common/timer.hpp PRE-CREATION > src/common/try.hpp d75c624 > src/common/utils.hpp 5ad3585 > src/common/utils.cpp 572f04c > src/common/uuid.hpp 230aa21 > src/common/values.hpp PRE-CREATION > src/common/values.cpp PRE-CREATION > src/configurator/configuration.hpp 7addfa4 > src/detector/detector.cpp ef4aff7 > src/examples/cpp_test_framework.cpp ab02805 > src/examples/java/TestExceptionFramework.java ba39757 > src/examples/java/TestExecutor.java e40a8c8 > src/examples/java/TestFramework.java e1b6032 > src/examples/java/TestMultipleExecutorsFramework.java a49ecbb > src/examples/long_lived_framework.cpp 4003e47 > src/examples/memhog.cpp 339d238 > src/examples/python/test_executor.py 436ab8f > src/examples/python/test_framework.py e6893cf > src/examples/scheduled_memhog.cpp 5d01aef > src/exec/exec.cpp b27c241 > src/java/jni/convert.cpp 04a25dd > src/java/jni/org_apache_mesos_Log.cpp fc056ad > src/java/jni/org_apache_mesos_MesosExecutorDriver.cpp 87258f6 > src/java/mesos.pom e5b674d > src/java/src/org/apache/mesos/Executor.java 5ad8cee > src/java/src/org/apache/mesos/ExecutorDriver.java be01d21 > src/java/src/org/apache/mesos/Log.java b794714 > src/java/src/org/apache/mesos/MesosExecutorDriver.java 399c8b8 > src/java/src/org/apache/mesos/MesosSchedulerDriver.java 04809a6 > src/java/src/org/apache/mesos/Scheduler.java 63a06fe > src/java/src/org/apache/mesos/SchedulerDriver.java 23a246c > src/log/cache.hpp 7d19c5d > src/log/coordinator.hpp 5ee44d2 > src/log/coordinator.cpp d05538d > src/log/log.hpp e50969b > src/log/log.cpp 7386a9d > src/log/main.cpp 4162db5 > src/log/network.hpp c88822c > src/log/replica.hpp a4cdf84 > src/log/replica.cpp e60f4df > src/master/constants.hpp f3cbe84 > src/master/frameworks_manager.hpp bf97d5f > src/master/frameworks_manager.cpp 30fa325 > src/master/http.hpp 30ab1ff > src/master/http.cpp 8937fee > src/master/master.hpp 6514c56 > src/master/master.cpp 68aea40 > src/master/simple_allocator.cpp 28d8186 > src/messages/log.hpp 24f8cc8 > src/messages/log.proto c88153c > src/messages/messages.proto a9cbcdc > src/python/native/mesos_executor_driver_impl.hpp 4fed126 > src/python/native/mesos_executor_driver_impl.cpp ed4aaa5 > src/python/src/mesos.py 5fc60e2 > src/scaling/nested_exec.py 5c4edf1 > src/scaling/scaling_exec.py 4b56360 > src/scaling/scaling_sched.py c94fdab > src/sched/sched.cpp 7f4e980 > src/slave/constants.hpp 489640b > src/slave/http.hpp 0b2930a > src/slave/http.cpp 18efd8c > src/slave/lxc_isolation_module.cpp ab0843a > src/slave/slave.hpp 37bbd8c > src/slave/slave.cpp 665ab7f > src/tests/Makefile.in ea943f7 > src/tests/attributes_test.cpp PRE-CREATION > src/tests/base_zookeeper_test.hpp e7bb7ed > src/tests/base_zookeeper_test.cpp 202b66b > src/tests/exception_tests.cpp 62f4fb6 > src/tests/fault_tolerance_tests.cpp ebb7709 > src/tests/jvm.hpp 5dfa617 > src/tests/jvm.cpp 78993b3 > src/tests/killtree_tests.cpp af19a3a > src/tests/log_tests.cpp c6bbdd1 > src/tests/master_tests.cpp a1f5007 > src/tests/multihashmap_tests.cpp e84e4eb > src/tests/process_spawn.cpp 8b5fab4 > src/tests/protobuf_io_tests.cpp 52aec0d > src/tests/resource_offers_tests.cpp 8e1061e > src/tests/resources_tests.cpp 11366c6 > src/tests/strings_tests.cpp 7e4bb69 > src/tests/url_processor_tests.cpp 0614670 > src/tests/utils.hpp 65ce4df > src/tests/utils_tests.cpp 0083f38 > src/tests/values_tests.cpp PRE-CREATION > src/tests/zookeeper_server.hpp cac9f0d > src/tests/zookeeper_server.cpp 3927785 > src/tests/zookeeper_server_tests.cpp 2a21030 > src/tests/zookeeper_tests.cpp 0c68a88 > src/webui/master/framework.tpl fb2077d > src/webui/master/index.tpl bc0cd0b > src/webui/static/stylesheet.css 5b2d9fd > src/zookeeper/zookeeper.hpp a58685e > src/zookeeper/zookeeper.cpp c1aa827 > third_party/libprocess/include/process/http.hpp baa911a > third_party/libprocess/src/process.cpp d77b156 > > Diff: https://reviews.apache.org/r/3416/diff > > > Testing > ------- > > ./bin/tests/all-tests > > > Thanks, > > Benjamin > >
