[
https://issues.apache.org/jira/browse/MESOS-45?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13183306#comment-13183306
]
[email protected] commented on MESOS-45:
----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3442/#review4294
-----------------------------------------------------------
This is very, very helpful. Thanks.
I focused on the javadoc but threw in java api nits as well (from the
perspective of a mesos library maintainer).
The javadoc should really follow
http://www.oracle.com/technetwork/java/javase/documentation/index-137868.html,
but the most glaring omissions are @parameter,@return docs.
src/java/src/org/apache/mesos/Scheduler.java
<https://reviews.apache.org/r/3442/#comment9675>
The driver parameter in all methods other than register deserves
explanation - must I use the it in the scope of the callback or is it always
the same as the regsitered or ...?
src/java/src/org/apache/mesos/Scheduler.java
<https://reviews.apache.org/r/3442/#comment9676>
There appears to be no need fo indexed access - Collection if you want to
provide size, but it seems Iterable is fine here.
src/java/src/org/apache/mesos/SchedulerDriver.java
<https://reviews.apache.org/r/3442/#comment9671>
s/public // - these are redundant for interface members
src/java/src/org/apache/mesos/SchedulerDriver.java
<https://reviews.apache.org/r/3442/#comment9672>
how does this stop relate to the overload? failover=true or false?
src/java/src/org/apache/mesos/SchedulerDriver.java
<https://reviews.apache.org/r/3442/#comment9673>
Is Iterable enough for the impl? - if so prefer it.
- John
On 2012-01-10 06:48:03, Benjamin Hindman wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/3442/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-01-10 06:48:03)
bq.
bq.
bq. Review request for mesos, Andy Konwinski, Charles Reiss, Matei Zaharia,
John Sirois, and Vinod Kone.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Provides initial documentation to the public interfaces (thanks to Vinod
Kone for pairing with me on this).
bq.
bq.
bq. This addresses bug MESOS-45.
bq. https://issues.apache.org/jira/browse/MESOS-45
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. include/mesos/executor.hpp d883f1a
bq. include/mesos/mesos.proto 77a9067
bq. include/mesos/scheduler.hpp 93dda98
bq. src/java/src/org/apache/mesos/Executor.java 5ad8cee
bq. src/java/src/org/apache/mesos/ExecutorDriver.java be01d21
bq. src/java/src/org/apache/mesos/MesosExecutorDriver.java 399c8b8
bq. src/java/src/org/apache/mesos/MesosSchedulerDriver.java 04809a6
bq. src/java/src/org/apache/mesos/Scheduler.java 63a06fe
bq. src/java/src/org/apache/mesos/SchedulerDriver.java 23a246c
bq. src/python/src/mesos.py 5fc60e2
bq.
bq. Diff: https://reviews.apache.org/r/3442/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq.
bq. Thanks,
bq.
bq. Benjamin
bq.
bq.
> Document semantics and state transitions in mesos user-pluggable interfaces
> ---------------------------------------------------------------------------
>
> Key: MESOS-45
> URL: https://issues.apache.org/jira/browse/MESOS-45
> Project: Mesos
> Issue Type: Improvement
> Components: c++-api, java-api, python-api
> Reporter: John Sirois
>
> In particular, scheduler and executor lifecycle and re-entrancy requirements
> should be documented well either centrally, in a HOW-TO/spec or better,
> additionally or solely in binding interfaces in the supported languages (cpp,
> java, python).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
