[ 
https://issues.apache.org/jira/browse/MESOS-128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13190744#comment-13190744
 ] 

[email protected] commented on MESOS-128:
-----------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3582/
-----------------------------------------------------------

Review request for mesos.


Summary
-------

Adds missing Jvm::Attach to ZooKeeperServer::createTempDir().

Also checks the return value of JNI attach/detach calls.


This addresses bug MESOS-128.
    https://issues.apache.org/jira/browse/MESOS-128


Diffs
-----

  src/jvm/jvm.cpp 8f6e22b 
  src/tests/zookeeper_server.cpp 14c8f84 

Diff: https://reviews.apache.org/r/3582/diff


Testing
-------


Thanks,

Charles


                
> tests/zookeeper_server.cpp doesn't use Jvm::Attach in createTempDir()
> ---------------------------------------------------------------------
>
>                 Key: MESOS-128
>                 URL: https://issues.apache.org/jira/browse/MESOS-128
>             Project: Mesos
>          Issue Type: Bug
>          Components: test
>            Reporter: Charles Reiss
>            Assignee: Charles Reiss
>            Priority: Trivial
>              Labels: jni, test
>
> ZooKeeperServer::createTempDir calls jvm->invoke without creating a 
> Jvm::Attach object.
> I'm not sure if this causes any problems, but I noticed it while looking at 
> some hard to reproduce mesos-tests crashes.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to