-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3580/
-----------------------------------------------------------
(Updated 2012-01-23 07:02:50.324655)
Review request for mesos.
Changes
-------
Another thing about the libtool options not being gcc options is that they the
configure test that calls $CC directly can't use them. Adjusted to add internal
TEST_JAVA_LDFLAGS for the "can-we-link" test. (Apparently, my first test
platform had a particularly generous version of GCC on this point.) Also moved
the library to the end for cases where that matters.
Summary
-------
On Linux, I've needed to build with -Wl,-rpath to nicely link against -ljvm. We
should do something like this automatically.
This patch (on Linux only) uses -Wl,-ljvm instead of -ljvm to link -ljvm so
libtool doesn't add it to dependency_libs [*]. Besides hopefully being
unnecessary, it fails to link things linked against that libtool library
because libtool doesn't add the rpath for the java libraries (even if I specify
it with -R). This also requires that the flags be added on libmesos.la and uses
the assumption that libmesos.la is linked dynamically.
[*] Things added to dependency_libs are automatically linked into any
executables linking against the library; this would be fine (and would make
sense if our header files might contain inline functions that call JNI_* calls)
if the -R settings were properly passed through, but libtool does not appear to
do this.
This addresses bug MESOS-127.
https://issues.apache.org/jira/browse/MESOS-127
Diffs (updated)
-----
configure.ac bda6769
src/Makefile.am b8fc58e
Diff: https://reviews.apache.org/r/3580/diff
Testing
-------
Thanks,
Charles
