----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3579/#review4545 -----------------------------------------------------------
Just a few minor nits to hopefully help with readability in the future. Thanks! Makefile.am <https://reviews.apache.org/r/3579/#comment10137> Please move this up to line 42. src/Makefile.am <https://reviews.apache.org/r/3579/#comment10138> Wait, shouldn't that be libprotobuf.la? src/Makefile.am <https://reviews.apache.org/r/3579/#comment10139> Awesome, but let's move this comment and the Mesos JAR* stuff above the protobuf stuff (outside the 'if HAS_JAVA') and then only have a single if HAS_JAVA block here. src/Makefile.am <https://reviews.apache.org/r/3579/#comment10140> No need to start with the empty line. src/Makefile.am <https://reviews.apache.org/r/3579/#comment10141> Add small comment about this as you did with the Java stuff above. - Benjamin On 2012-01-22 21:49:18, Charles Reiss wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/3579/ > ----------------------------------------------------------- > > (Updated 2012-01-22 21:49:18) > > > Review request for mesos. > > > Summary > ------- > > Add some missing files in src/ and include/ to distribution and makes header > files be installed (under $(pkgincludedir) = $(includedir)/mesos = > $(prefix)/include/mesos by default). > > > This addresses bugs MESOS-119 and MESOS-120. > https://issues.apache.org/jira/browse/MESOS-119 > https://issues.apache.org/jira/browse/MESOS-120 > > > Diffs > ----- > > Makefile.am f26e555 > src/Makefile.am b8fc58e > > Diff: https://reviews.apache.org/r/3579/diff > > > Testing > ------- > > > Thanks, > > Charles > >
