> On 2012-01-24 21:29:45, Benjamin Hindman wrote: > > src/examples/python/test-executor.in, line 18 > > <https://reviews.apache.org/r/3589/diff/1/?file=70267#file70267line18> > > > > What's the benefit of using 'echo' rather than 'ls' to expand the > > wildcards? I'm happy using 'echo', but then I'd prefer that we do that > > everywhere in this file (and others) for consistency.
If the file doesn't exist ls will return the empty string (and print a message to stderr), so the error message won't make sense. Changed both files to use echo. > On 2012-01-24 21:29:45, Benjamin Hindman wrote: > > src/examples/python/test-executor.in, line 43 > > <https://reviews.apache.org/r/3589/diff/1/?file=70267#file70267line43> > > > > I had intentionally removed this. If it's needed, please provide a > > comment as to why we it's necessary. Re-removed. > On 2012-01-24 21:29:45, Benjamin Hindman wrote: > > src/examples/python/test-executor.in, line 45 > > <https://reviews.apache.org/r/3589/diff/1/?file=70267#file70267line45> > > > > Please wrap this at 'exec ${PYTHON} ...', here and in the other file > > too. Done. - Charles ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3589/#review4563 ----------------------------------------------------------- On 2012-01-25 19:12:32, Charles Reiss wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/3589/ > ----------------------------------------------------------- > > (Updated 2012-01-25 19:12:32) > > > Review request for mesos. > > > Summary > ------- > > Fixes MESOS-130. > > > This addresses bug MESOS-130. > https://issues.apache.org/jira/browse/MESOS-130 > > > Diffs > ----- > > src/examples/python/test-executor.in 7cf2e27 > src/examples/python/test-framework.in 2a557cf > > Diff: https://reviews.apache.org/r/3589/diff > > > Testing > ------- > > > Thanks, > > Charles > >
