[
https://issues.apache.org/jira/browse/MESOS-130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13193225#comment-13193225
]
[email protected] commented on MESOS-130:
-----------------------------------------------------
bq. On 2012-01-24 21:29:45, Benjamin Hindman wrote:
bq. > src/examples/python/test-executor.in, line 18
bq. > <https://reviews.apache.org/r/3589/diff/1/?file=70267#file70267line18>
bq. >
bq. > What's the benefit of using 'echo' rather than 'ls' to expand the
wildcards? I'm happy using 'echo', but then I'd prefer that we do that
everywhere in this file (and others) for consistency.
If the file doesn't exist ls will return the empty string (and print a message
to stderr), so the error message won't make sense. Changed both files to use
echo.
bq. On 2012-01-24 21:29:45, Benjamin Hindman wrote:
bq. > src/examples/python/test-executor.in, line 43
bq. > <https://reviews.apache.org/r/3589/diff/1/?file=70267#file70267line43>
bq. >
bq. > I had intentionally removed this. If it's needed, please provide a
comment as to why we it's necessary.
Re-removed.
bq. On 2012-01-24 21:29:45, Benjamin Hindman wrote:
bq. > src/examples/python/test-executor.in, line 45
bq. > <https://reviews.apache.org/r/3589/diff/1/?file=70267#file70267line45>
bq. >
bq. > Please wrap this at 'exec ${PYTHON} ...', here and in the other file
too.
Done.
- Charles
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3589/#review4563
-----------------------------------------------------------
On 2012-01-25 19:12:32, Charles Reiss wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/3589/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-01-25 19:12:32)
bq.
bq.
bq. Review request for mesos.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Fixes MESOS-130.
bq.
bq.
bq. This addresses bug MESOS-130.
bq. https://issues.apache.org/jira/browse/MESOS-130
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. src/examples/python/test-executor.in 7cf2e27
bq. src/examples/python/test-framework.in 2a557cf
bq.
bq. Diff: https://reviews.apache.org/r/3589/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq.
bq. Thanks,
bq.
bq. Charles
bq.
bq.
> Python tests require setuptools to be installed
> -----------------------------------------------
>
> Key: MESOS-130
> URL: https://issues.apache.org/jira/browse/MESOS-130
> Project: Mesos
> Issue Type: Bug
> Components: python-api, test
> Reporter: Charles Reiss
> Assignee: Charles Reiss
> Priority: Trivial
>
> Even though we bundle a distribute egg with Mesos, the python tests don't
> work if setuptools aren't installed.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
