> On 2012-01-24 22:13:17, Benjamin Hindman wrote: > > src/Makefile.am, line 236 > > <https://reviews.apache.org/r/3590/diff/1/?file=70271#file70271line236> > > > > Cool, does this mean we can also remove all WEBUI_LDFLAGS from the > > binaries too?
Apparently. Removed. - Charles ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3590/#review4570 ----------------------------------------------------------- On 2012-01-25 19:43:17, Charles Reiss wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/3590/ > ----------------------------------------------------------- > > (Updated 2012-01-25 19:43:17) > > > Review request for mesos. > > > Summary > ------- > > This can be necessary to link mesos-master because the -lpython* flag needs > to end up after libwebui.a on some systems. Using LIBADD tells libtool that > libwebui.a depends on it so it generates an appropriately ordered linking > command. > > > This addresses bug MESOS-131. > https://issues.apache.org/jira/browse/MESOS-131 > > > Diffs > ----- > > src/Makefile.am 48727ae > > Diff: https://reviews.apache.org/r/3590/diff > > > Testing > ------- > > > Thanks, > > Charles > >
