----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3498/#review4709 -----------------------------------------------------------
src/master/main.cpp <https://reviews.apache.org/r/3498/#comment10431> Remove trailing whitespace (and in each other .cpp/.hpp change). - Charles On 2012-01-14 05:42:06, Sam Pullman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/3498/ > ----------------------------------------------------------- > > (Updated 2012-01-14 05:42:06) > > > Review request for mesos, Benjamin Hindman and Andy Konwinski. > > > Summary > ------- > > Moved configuration setup from the main.cpp files in the slave and master > directories to the registerOption functions in slave.cpp and master.cpp. Made > the default listening port and WebUI ports constants, and made the constants > marked with TODOs in master/constants.hpp configurable. I made a git patch > because I wasn't sure if the review board accepts svn patches (the one I > uploaded to the JIRA was svn). > > > This addresses bug MESOS-116. > https://issues.apache.org/jira/browse/MESOS-116 > > > Diffs > ----- > > src/master/constants.hpp 8248475 > src/master/main.cpp e427ff7 > src/master/master.cpp b56c732 > src/slave/constants.hpp f0c8679 > src/slave/main.cpp 9519ed2 > src/slave/slave.cpp 62fc277 > > Diff: https://reviews.apache.org/r/3498/diff > > > Testing > ------- > > > Thanks, > > Sam > >
