[
https://issues.apache.org/jira/browse/MESOS-116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13197111#comment-13197111
]
[email protected] commented on MESOS-116:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3498/#review4709
-----------------------------------------------------------
src/master/main.cpp
<https://reviews.apache.org/r/3498/#comment10431>
Remove trailing whitespace (and in each other .cpp/.hpp change).
- Charles
On 2012-01-14 05:42:06, Sam Pullman wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/3498/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-01-14 05:42:06)
bq.
bq.
bq. Review request for mesos, Benjamin Hindman and Andy Konwinski.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Moved configuration setup from the main.cpp files in the slave and master
directories to the registerOption functions in slave.cpp and master.cpp. Made
the default listening port and WebUI ports constants, and made the constants
marked with TODOs in master/constants.hpp configurable. I made a git patch
because I wasn't sure if the review board accepts svn patches (the one I
uploaded to the JIRA was svn).
bq.
bq.
bq. This addresses bug MESOS-116.
bq. https://issues.apache.org/jira/browse/MESOS-116
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. src/master/constants.hpp 8248475
bq. src/master/main.cpp e427ff7
bq. src/master/master.cpp b56c732
bq. src/slave/constants.hpp f0c8679
bq. src/slave/main.cpp 9519ed2
bq. src/slave/slave.cpp 62fc277
bq.
bq. Diff: https://reviews.apache.org/r/3498/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq.
bq. Thanks,
bq.
bq. Sam
bq.
bq.
> Make default configuration values constants and make certain constants
> configurable
> -----------------------------------------------------------------------------------
>
> Key: MESOS-116
> URL: https://issues.apache.org/jira/browse/MESOS-116
> Project: Mesos
> Issue Type: Improvement
> Reporter: Sam Pullman
> Priority: Minor
> Labels: configuration
> Attachments: MESOS-116.patch
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> Change hard-coded default configuration values in master and slave setup to
> be constants. Update configuration options to include constants in master
> marked with TODOs.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
