[
https://issues.apache.org/jira/browse/MESOS-120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13197519#comment-13197519
]
[email protected] commented on MESOS-120:
-----------------------------------------------------
bq. On 2012-02-01 00:19:15, Benjamin Hindman wrote:
bq. > third_party/Makefile.am, line 4
bq. > <https://reviews.apache.org/r/3588/diff/3/?file=70277#file70277line4>
bq. >
bq. > Why @SUBCONFIG_ARGS@ instead of $(SUBCONFIG_ARGS)?
That would be recursive on this line (since we are defining SUBCONFIG_ARGS for
make purposes but not .in substitution purposes).
bq. On 2012-02-01 00:19:15, Benjamin Hindman wrote:
bq. > src/Makefile.am, lines 22-23
bq. > <https://reviews.apache.org/r/3588/diff/3/?file=70274#file70274line22>
bq. >
bq. > s/move/Move and kill tab (or indentation).
Done.
bq. On 2012-02-01 00:19:15, Benjamin Hindman wrote:
bq. > third_party/Makefile.am, line 2
bq. > <https://reviews.apache.org/r/3588/diff/3/?file=70277#file70277line2>
bq. >
bq. > Not used.
Removed.
bq. On 2012-02-01 00:19:15, Benjamin Hindman wrote:
bq. > third_party/Makefile.am, line 73
bq. > <https://reviews.apache.org/r/3588/diff/3/?file=70277#file70277line73>
bq. >
bq. > Kill tab.
Done.
bq. On 2012-02-01 00:19:15, Benjamin Hindman wrote:
bq. > third_party/Makefile.am, line 48
bq. > <https://reviews.apache.org/r/3588/diff/3/?file=70277#file70277line48>
bq. >
bq. > Wrap for 80 characters please (and everywhere else in this file).
Done.
bq. On 2012-02-01 00:19:15, Benjamin Hindman wrote:
bq. > src/Makefile.am, line 45
bq. > <https://reviews.apache.org/r/3588/diff/3/?file=70274#file70274line45>
bq. >
bq. > Wrap for 80 characters please.
Done.
bq. On 2012-02-01 00:19:15, Benjamin Hindman wrote:
bq. > src/Makefile.am, lines 77-78
bq. > <https://reviews.apache.org/r/3588/diff/3/?file=70274#file70274line77>
bq. >
bq. > I've replaced '$(top_builddir)' with '..' everywhere else in the
file.
You haven't, but replaced my additions of $(top_builddir) with ..
- Charles
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3588/#review4725
-----------------------------------------------------------
On 2012-02-01 02:25:11, Charles Reiss wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/3588/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-02-01 02:25:11)
bq.
bq.
bq. Review request for mesos.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Builds third_party from tarballs instead of having us distribute the
unpacked source.
bq.
bq. To make it sane to review, this patch does not include the tarballs or the
removal of the original third_party directories. Everything but distribute-*
should be put into tarballs for this to work.
bq.
bq.
bq. This addresses bug MESOS-120.
bq. https://issues.apache.org/jira/browse/MESOS-120
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. Makefile.am d979bbb
bq. Makefile.am d979bbb
bq. configure.ac 283b49a
bq. configure.ac 283b49a
bq. src/Makefile.am ac0a209
bq. src/Makefile.am ac0a209
bq. src/examples/python/test-executor.in d730116
bq. src/examples/python/test-executor.in d730116
bq. src/examples/python/test-framework.in 0f6a6a9
bq. src/examples/python/test-framework.in 0f6a6a9
bq. src/python/setup.py.in 07aaa58
bq. src/python/setup.py.in 07aaa58
bq. src/tests/base_zookeeper_test.cpp 872bffb
bq. src/tests/base_zookeeper_test.cpp 872bffb
bq. third_party/Makefile.am PRE-CREATION
bq. third_party/Makefile.am PRE-CREATION
bq.
bq. Diff: https://reviews.apache.org/r/3588/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq.
bq. Thanks,
bq.
bq. Charles
bq.
bq.
> Get 'make dist' working correctly
> ---------------------------------
>
> Key: MESOS-120
> URL: https://issues.apache.org/jira/browse/MESOS-120
> Project: Mesos
> Issue Type: Sub-task
> Reporter: Benjamin Hindman
> Assignee: Charles Reiss
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
