[
https://issues.apache.org/jira/browse/MESOS-8?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13197566#comment-13197566
]
[email protected] commented on MESOS-8:
---------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2990/
-----------------------------------------------------------
(Updated 2012-02-01 04:03:33.220793)
Review request for mesos, Benjamin Hindman and Andy Konwinski.
Changes
-------
The problem seemed to be that the default copy constructor for Executor was
only copying the pointers to the Tasks in launchedTasks but the destructor was
deleting those objects. When an Executor was shut down abnormally, so that
there were still some Tasks in launchedTasks, the copy of the Executor we're
making to put in the completedExecutor deque tries to access the pointers in
launchedTasks and the objects aren't there anymore.
So, I'm not sure if this is the best solution, but I wrote a copy constructor
for the Executor class that copies the Task objects themselves, and that fixed
it.
Summary
-------
Added a framework history to the slave page, an executor history to the
framework page, and a task history to the executor page. Allows stdout and
stderr of executors to be viewed after they finish executing.
This addresses bug MESOS-8.
https://issues.apache.org/jira/browse/MESOS-8
Diffs (updated)
-----
src/slave/constants.hpp f0c8679
src/slave/http.cpp f03815d
src/slave/slave.hpp b1a07e9
src/slave/slave.cpp 9b33a5a
src/webui/slave/executor.tpl dd53464
src/webui/slave/framework.tpl 9488da5
src/webui/slave/index.tpl 0f18de6
Diff: https://reviews.apache.org/r/2990/diff
Testing
-------
Thanks,
Thomas
> Maintain a history of executed frameworks/tasks and show it on the web UI
> -------------------------------------------------------------------------
>
> Key: MESOS-8
> URL: https://issues.apache.org/jira/browse/MESOS-8
> Project: Mesos
> Issue Type: Improvement
> Reporter: Matei Zaharia
> Assignee: Thomas Marshall
>
> This is kind of a big task but ultimately important for cluster management.
> See https://github.com/mesos/mesos/issues#issue/39 for previous discussion on
> GitHub.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
