----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3783/#review4949 -----------------------------------------------------------
Ship it! Awesome! Thank you! - Benjamin On 2012-02-08 00:03:17, Charles Reiss wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/3783/ > ----------------------------------------------------------- > > (Updated 2012-02-08 00:03:17) > > > Review request for mesos and Benjamin Hindman. > > > Summary > ------- > > This fixes some memory leaks of utility classes found through valgrind: > > - the Slave never frees its Framework or Executor objects (this probably only > affects the tests); > - the Master does not free its TaskDescriptionVisitor objects properly > because the superclass does not have a virtual destructor (this is likely a > slow memory leak for a running Master); > > > Diffs > ----- > > src/master/master.cpp fd9e6fd > src/slave/slave.cpp 9b33a5a > > Diff: https://reviews.apache.org/r/3783/diff > > > Testing > ------- > > > Thanks, > > Charles > >
