----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3795/#review4950 -----------------------------------------------------------
Ship it! Cool, thanks. - Benjamin On 2012-02-08 07:32:57, Charles Reiss wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/3795/ > ----------------------------------------------------------- > > (Updated 2012-02-08 07:32:57) > > > Review request for mesos. > > > Summary > ------- > > The current Resources::operator== only checks resource types that exist in > the LHS, so it is not reflexive and the empty set of resources is equal to > all other sets of resources. I assume this is a bug, though it doesn't appear > to change the outcome of any tests. > > > Diffs > ----- > > src/common/resources.hpp 4210f85 > src/tests/resources_tests.cpp dc0637a > > Diff: https://reviews.apache.org/r/3795/diff > > > Testing > ------- > > make check > > > Thanks, > > Charles > >
