[
https://issues.apache.org/jira/browse/MESOS-46?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13207287#comment-13207287
]
[email protected] commented on MESOS-46:
----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2664/
-----------------------------------------------------------
(Updated 2012-02-13 22:31:04.818047)
Review request for mesos.
Changes
-------
Merged with trunk.
Summary (updated)
-------
This patch refactors MasterTest.* tests to use a test fixture, eliminating a
bunch of redundant setup/teardown code. It also renames it to MasterSlaveTest
to reflect that the current MasterTest actually tests both
mesos::internal::master::Master and mesos::internal::slave::Slave together.
This addresses bug MESOS-46.
https://issues.apache.org/jira/browse/MESOS-46
Diffs (updated)
-----
src/tests/master_tests.cpp a411ba5
Diff: https://reviews.apache.org/r/2664/diff
Testing
-------
Thanks,
Charles
> Refactor MasterTest to use fixture
> ----------------------------------
>
> Key: MESOS-46
> URL: https://issues.apache.org/jira/browse/MESOS-46
> Project: Mesos
> Issue Type: Improvement
> Components: test
> Reporter: Charles Reiss
> Assignee: Charles Reiss
> Priority: Trivial
> Labels: patch
> Attachments: 0001-Refactor-MasterTests-to-use-fixture.patch
>
>
> master_test.cpp contains a lot of redundant code Master/Slave/SchedulerDriver
> setup code that should be refactored into a test fixture.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
