----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3761/ -----------------------------------------------------------
(Updated 2012-02-15 00:44:10.891115) Review request for mesos, Benjamin Hindman, John Sirois, and Brian Wickman. Changes ------- ben's comments Summary ------- Currently, the init() callback in Executor is not consistent with the naming of our callbacks. Like scheduler callback, this should be called registered(). In the near future, we are also going to add a new executor callback called re-registered() as we implement slaves being restarted without killing executors. As part of this, also got rid of the ExecutorArgs protobuf. Diffs (updated) ----- frameworks/hadoop-0.20.2/src/contrib/mesos/src/java/org/apache/hadoop/mapred/FrameworkExecutor.java 6744082 include/mesos/executor.hpp 8e651e7 include/mesos/mesos.proto b855f70 src/examples/java/TestExecutor.java 6211490 src/examples/long_lived_executor.cpp 6ba083b src/examples/memhog_executor.cpp 333b1d9 src/examples/test_executor.cpp 9dd244e src/exec/exec.cpp 48c0d0f src/java/jni/convert.cpp 04a25dd src/java/jni/org_apache_mesos_MesosExecutorDriver.cpp b338847 src/java/src/org/apache/mesos/Executor.java a05591f src/messages/messages.proto 04dc3a0 src/python/native/proxy_executor.hpp 3ed9e37 src/python/native/proxy_executor.cpp 30cf089 src/python/src/mesos.py 026a611 src/scaling/nested_exec.py 5c4edf1 src/sched/sched.cpp 21d670f src/slave/slave.cpp 9b33a5a src/tests/fault_tolerance_tests.cpp 7be3d6b src/tests/master_tests.cpp a411ba5 src/tests/utils.hpp 660aee9 Diff: https://reviews.apache.org/r/3761/diff Testing ------- ./mesos-tests --gtest_filter = -"*Python*" All the tests, except the SamplePythonFramework, pass. Looking at earlier Jiras, looks like there is a fix for python tests, that needs to be pushed to the trunk? I'm not sure if that fixes this test fail yet. Thanks, Vinod
