----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3872/#review5137 -----------------------------------------------------------
src/tests/base_zookeeper_test.cpp <https://reviews.apache.org/r/3872/#comment11240> I've killed this, FYI. - Benjamin On 2012-02-12 00:04:59, Charles Reiss wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/3872/ > ----------------------------------------------------------- > > (Updated 2012-02-12 00:04:59) > > > Review request for mesos and Benjamin Hindman. > > > Summary > ------- > > Note: For size, the patch does not include the zookeeper-3.3.4.tar.gz; it > will need to be acquired separately. > > This removes hard-coded version numbers from src/Makefile.am and > third_party/Makefile.am, moving them to a new third_party/versions.am file. > It removes hardcoded zookeeper version numbers in test code by passing the > zookeeper version in a -D compiler option. > > It also upgrades zookeeper from 3.3.1 to 3.3.4, which fixes > (warnings-related) build problems with recent GCCs. > > > Diffs > ----- > > src/Makefile.am f0806ab > src/tests/base_zookeeper_test.cpp 83fcf35 > third_party/Makefile.am c0e8937 > third_party/versions.am PRE-CREATION > third_party/zookeeper-3.3.1.tar.gz c67deed > third_party/zookeeper-3.3.4.tar.gz PRE-CREATION > > Diff: https://reviews.apache.org/r/3872/diff > > > Testing > ------- > > make check > > > Thanks, > > Charles > >
