> On 2012-02-29 03:55:00, Charles Reiss wrote: > > configure.macosx, line 15 > > <https://reviews.apache.org/r/4097/diff/1/?file=86412#file86412line15> > > > > Don't pass JAVA_HOME, JAVA_CPPFLAGS to configure at all if we didn't > > manage to set them. (If 'java' is on the PATH, we may figure out > > appropriate values anyways.)
Okay, cleaned up. > On 2012-02-29 03:55:00, Charles Reiss wrote: > > configure.ubuntu-karmic-64, line 1 > > <https://reviews.apache.org/r/4097/diff/1/?file=86421#file86421line1> > > > > karmic and hardy are pretty old (and no longer supported by Ubuntu) > > AFAICT? Any reason to keep these configure templates? No reason at all, I'll kill them! > On 2012-02-29 03:55:00, Charles Reiss wrote: > > configure.ubuntu-natty-64, line 3 > > <https://reviews.apache.org/r/4097/diff/1/?file=86423#file86423line3> > > > > Why Sun Java? Install default-jdk in natty yields OpenJDK 6. That's just what was there before. Are you saying I can kill the JAVA_HOME all together? - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4097/#review5431 ----------------------------------------------------------- On 2012-02-29 03:34:32, Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/4097/ > ----------------------------------------------------------- > > (Updated 2012-02-29 03:34:32) > > > Review request for mesos, Andy Konwinski, Charles Reiss, and John Sirois. > > > Summary > ------- > > See summary. > > > Diffs > ----- > > README b771e2d > bootstrap 30ec13f > configure.amazon-linux-64 PRE-CREATION > configure.centos-5.4-64 PRE-CREATION > configure.macosx PRE-CREATION > configure.template.amazon-linux-64 3b9faff > configure.template.centos-5.4-64 e36355a > configure.template.macosx 2120b93 > configure.template.ubuntu-hardy-64 415c16f > configure.template.ubuntu-karmic-64 e7ec0f2 > configure.template.ubuntu-lucid-64 53e9c40 > configure.template.ubuntu-natty-64 0cfb5d3 > configure.ubuntu-hardy-64 PRE-CREATION > configure.ubuntu-karmic-64 PRE-CREATION > configure.ubuntu-lucid-64 PRE-CREATION > configure.ubuntu-natty-64 PRE-CREATION > ec2/deploy.amazon64-old/root/mesos-ec2/setup 15347a7 > ec2/deploy.amazon64/root/mesos-ec2/setup e7ade00 > ec2/deploy.centos64/root/mesos-ec2/setup 0681942 > ec2/deploy.lucid64/root/mesos-ec2/setup 2eba89e > > Diff: https://reviews.apache.org/r/4097/diff > > > Testing > ------- > > > Thanks, > > Benjamin > >
