----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3957/#review5468 -----------------------------------------------------------
Just some minor style nits. src/common/attributes.hpp <https://reviews.apache.org/r/3957/#comment11864> s/operator==(/operator == ( src/common/attributes.hpp <https://reviews.apache.org/r/3957/#comment11865> Kill the else and just pull the code out. src/common/attributes.hpp <https://reviews.apache.org/r/3957/#comment11866> Indent 2. src/common/attributes.hpp <https://reviews.apache.org/r/3957/#comment11867> s/sets/Sets src/common/values.hpp <https://reviews.apache.org/r/3957/#comment11868> Kill newline. src/common/values.cpp <https://reviews.apache.org/r/3957/#comment11869> Kill extra space, add '{' at end of line (not sure why that wasn't there). src/tests/attributes_test.cpp <https://reviews.apache.org/r/3957/#comment11871> Indented an extra space? src/tests/attributes_test.cpp <https://reviews.apache.org/r/3957/#comment11872> This makes me think we should just add a '!=' operator. - Benjamin On 2012-02-19 04:33:49, Charles Reiss wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/3957/ > ----------------------------------------------------------- > > (Updated 2012-02-19 04:33:49) > > > Review request for mesos and Benjamin Hindman. > > > Summary > ------- > > I noticed that Attributes were missing an implementation of get() (despite a > prototype) and of operator==. This patch adds them. > > In the process, it does some other minor fixes: > - operator== for Value::* types are moved to common/values.{hpp,cpp} > - tests/attributes_tests.cpp is added as a source of mesos-tests (it was > previously not being compiled!) > > > Diffs > ----- > > src/Makefile.am c58e9d8 > src/common/attributes.hpp 210ceda > src/common/resources.hpp e4a826d > src/common/resources.cpp b036e42 > src/common/values.hpp 902a3d2 > src/common/values.cpp efe6859 > src/tests/attributes_test.cpp 3ceb48f > > Diff: https://reviews.apache.org/r/3957/diff > > > Testing > ------- > > > Thanks, > > Charles > >
