-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4100/#review5620
-----------------------------------------------------------


Nice work with the tutorial; it really streamlines Hadoop integration with 
Mesos. Just a couple issues to note. Last week I set up Mesos/Hadoop twice, 
once on Fedora 16 and the second time on Scientific Linux 6.2. 

The issues are the same for both systems. First, lines 71-80 in TUTORIAL.sh are 
incorrect for these distributions of Linux. Setting JAVA_HOME breaks 
installation when the script tries to find javac since, for reasons I have not 
tracked down, no matter what JAVA_HOME is set to at the beginning of the 
script, when it gets to the point where it needs javac, JAVA_HOME has changed 
to a completely wrong directory. Once I commented out these lines and made sure 
to unset JAVA_HOME, the script ran successfully to completion. (NOTE: I do have 
to set JAVA_HOME in hadoop-env.sh after installing, but setting it as an 
environment variable or within the TUTORIAL script will not work.)

Second, the hadoop-env.sh patch uses the wrong library for Linux systems. Line 
20 specifies the Mac OS X library, "libmesos.dylib," but the correct library is 
"libmesos.so." Perhaps multiple patches are needed, depending on the system.

- Jessica


On 2012-02-29 06:17:27, Benjamin Hindman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4100/
> -----------------------------------------------------------
> 
> (Updated 2012-02-29 06:17:27)
> 
> 
> Review request for mesos, Andy Konwinski, Charles Reiss, and Matei Zaharia.
> 
> 
> Summary
> -------
> 
> make && make hadoop
> 
> 
> Diffs
> -----
> 
>   Makefile.am abee0b9 
>   hadoop/TUTORIAL.sh PRE-CREATION 
>   hadoop/hadoop-0.20.205.0.patch PRE-CREATION 
>   hadoop/hadoop-0.20.205.0_conf_hadoop-env.sh.patch PRE-CREATION 
>   hadoop/hadoop-0.20.205.0_conf_mapred-site.xml.patch PRE-CREATION 
>   src/Makefile.am a1ff40c 
>   src/examples/java/TestExecutor.java 6211490 
>   src/java/jni/convert.cpp 04a25dd 
>   src/java/src/org/apache/mesos/Log.java 4612393 
>   src/java/src/org/apache/mesos/MesosExecutorDriver.java 4f110ca 
>   src/java/src/org/apache/mesos/MesosNativeLibrary.java PRE-CREATION 
>   src/java/src/org/apache/mesos/MesosSchedulerDriver.java f135ffb 
> 
> Diff: https://reviews.apache.org/r/4100/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Benjamin
> 
>

Reply via email to