> On 2012-03-02 14:09:15, Charles Reiss wrote: > > src/launcher/launcher.cpp, line 212 > > <https://reviews.apache.org/r/4119/diff/1/?file=86909#file86909line212> > > > > Check if this fails?
using the os::open wrapper now - in case an error happens the launcher would die. > On 2012-03-02 14:09:15, Charles Reiss wrote: > > src/launcher/launcher.cpp, line 222 > > <https://reviews.apache.org/r/4119/diff/1/?file=86909#file86909line222> > > > > Do you have some reason to believe that if this fails (e.g. connection > > closed before response is complete), then CURLINFO_RESPONSE_CODE won't be > > 200? checking now the actual curl error code, i.e. not just the http status code. > On 2012-03-02 14:09:15, Charles Reiss wrote: > > src/launcher/launcher.cpp, line 236 > > <https://reviews.apache.org/r/4119/diff/1/?file=86909#file86909line236> > > > > Check return value? (e.g. out of disk space/quota). done - Florian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4119/#review5539 ----------------------------------------------------------- On 2012-03-06 15:58:46, Florian Leibert wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/4119/ > ----------------------------------------------------------- > > (Updated 2012-03-06 15:58:46) > > > Review request for mesos and Benjamin Hindman. > > > Summary > ------- > > Launcher can now retrieve an executor specified as a HTTP Url. > Added dependencies of libcurl, ssl, crypto & z to the Makefile. > > > Diffs > ----- > > src/launcher/launcher.cpp 9bbae7e > src/Makefile.am 1d108ab > src/common/utils.hpp 5a88f17 > > Diff: https://reviews.apache.org/r/4119/diff > > > Testing > ------- > > > Thanks, > > Florian > >
