----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4302/#review5920 -----------------------------------------------------------
Ship it! Neat to see a no executor scheduler sample! src/examples/java/TestExceptionFramework.java <https://reviews.apache.org/r/4302/#comment12882> redundant - its fine style to omit a public default constructor - John On 2012-03-14 02:22:42, Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/4302/ > ----------------------------------------------------------- > > (Updated 2012-03-14 02:22:42) > > > Review request for mesos, John Sirois and Florian Leibert. > > > Summary > ------- > > Often times, you don't need an executor to run a task. When you do want an > executor, you'd like to launch it with a special command line, and use > environment variables to possibly "parameterize" that command line. This > patch provides those mechanisms. > > > Diffs > ----- > > hadoop/hadoop-0.20.205.0.patch 17643ae > include/mesos/executor.hpp bebe281 > include/mesos/mesos.proto 05cfe2d > include/mesos/scheduler.hpp fcb6bc1 > src/Makefile.am 10dbafd > src/common/utils.hpp 5a88f17 > src/examples/java/TestExceptionFramework.java 3435b83 > src/examples/java/TestExecutor.java 238cd63 > src/examples/java/TestFramework.java ff8eb4b > src/examples/java/TestMultipleExecutorsFramework.java 7367200 > src/examples/long_lived_executor.cpp 73d5616 > src/examples/long_lived_framework.cpp a7d6239 > src/examples/memhog.cpp 3cdc55c > src/examples/memhog_executor.cpp 6f672d1 > src/examples/no_executor_framework.cpp PRE-CREATION > src/examples/python/test_executor.py 436ab8f > src/examples/python/test_framework.py 9651f8b > src/examples/scheduled_memhog.cpp ab28e81 > src/examples/test_executor.cpp 9a3b657 > src/examples/test_framework.cpp ec9d436 > src/exec/exec.cpp aeb44be > src/java/src/org/apache/mesos/MesosExecutorDriver.java 81b3d1c > src/java/src/org/apache/mesos/MesosSchedulerDriver.java 78ad788 > src/launcher/executor.cpp PRE-CREATION > src/launcher/launcher.hpp 029f7da > src/launcher/launcher.cpp 9bbae7e > src/launcher/main.cpp 1c58b6a > src/master/http.cpp 591433a > src/master/master.cpp 1d3961e > src/python/setup.py.in c575732 > src/sched/sched.cpp 9f5866b > src/slave/http.cpp f03815d > src/slave/lxc_isolation_module.cpp d544625 > src/slave/process_based_isolation_module.cpp 100b1e3 > src/slave/slave.hpp b1a07e9 > src/slave/slave.cpp ce8fda5 > src/tests/exception_tests.cpp 91ac7fb > src/tests/fault_tolerance_tests.cpp 70cd6fb > src/tests/master_tests.cpp 008a83a > src/tests/utils.hpp 36d09e7 > > Diff: https://reviews.apache.org/r/4302/diff > > > Testing > ------- > > make && make check && make hadoop > > > Thanks, > > Benjamin > >
