> On 2012-03-15 22:31:07, John Sirois wrote: > >
Thanks all, submitting. > On 2012-03-15 22:31:07, John Sirois wrote: > > src/tests/external/SampleFrameworks/NoExecutorFramework.sh, line 5 > > <https://reviews.apache.org/r/4371/diff/1/?file=92874#file92874line5> > > > > this seems pretty round-about compared to > > test -z "$MESOS_SOURCE_DIR" && ... > > > > I think this must be standard/portable test ... aix certainly had it > > way back when. Using env I can actually test if it's set, versus testing whether or not it was set to the empty string. - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4371/#review6006 ----------------------------------------------------------- On 2012-03-15 22:25:08, Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/4371/ > ----------------------------------------------------------- > > (Updated 2012-03-15 22:25:08) > > > Review request for mesos, John Sirois and Vinod Kone. > > > Summary > ------- > > See summary. > > > Diffs > ----- > > src/tests/external/SampleFrameworks/NoExecutorFramework.sh PRE-CREATION > src/tests/sample_frameworks_tests.cpp a391928 > > Diff: https://reviews.apache.org/r/4371/diff > > > Testing > ------- > > make check > > > Thanks, > > Benjamin > >
