----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4396/ -----------------------------------------------------------
Review request for mesos and Benjamin Hindman. Summary ------- Fixes missing virtual destructors, return statements, braces found by enabling GCC a lot of warnings over Mesos. Diffs ----- src/common/factory.hpp cf543c7 src/common/thread.hpp 8636e37 src/configurator/option.hpp 77d99f2 src/detector/detector.cpp 23dc16e src/master/master.cpp 0222bb2 src/slave/slave.hpp de304cb src/slave/slave.cpp ddd1874 src/zookeeper/zookeeper.hpp 2de5864 Diff: https://reviews.apache.org/r/4396/diff Testing ------- Thanks, Charles
