> On 2012-03-22 23:30:40, John Sirois wrote: > > src/common/type_utils.hpp, line 174 > > <https://reviews.apache.org/r/4448/diff/2/?file=94648#file94648line174> > > > > Why are these needed vs protobuf builtins? Comments might help > > maintainers. Presumably you do this to get values-equals over a subset of > > protobuf fields.
Interestingly there are no protobuf builtins that I know of, so you have to do it yourself! I'll add some comments at the top of the file. - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4448/#review6261 ----------------------------------------------------------- On 2012-03-22 19:31:32, Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/4448/ > ----------------------------------------------------------- > > (Updated 2012-03-22 19:31:32) > > > Review request for mesos, Matei Zaharia, John Sirois, and Vinod Kone. > > > Summary > ------- > > See summary. > > > Diffs > ----- > > hadoop/hadoop-0.20.205.0.patch 909a41e > include/mesos/mesos.proto 478f561 > include/mesos/scheduler.hpp 34018f5 > src/common/type_utils.hpp efa1a84 > src/examples/java/TestExceptionFramework.java 6859c91 > src/examples/java/TestFramework.java fcfac40 > src/examples/java/TestMultipleExecutorsFramework.java 03a104b > src/examples/long_lived_framework.cpp 9ca49e5 > src/examples/no_executor_framework.cpp f6aa601 > src/examples/python/test_framework.py 388f7c0 > src/examples/test_framework.cpp f97d080 > src/java/jni/org_apache_mesos_MesosSchedulerDriver.cpp 3857be3 > src/java/src/org/apache/mesos/MesosSchedulerDriver.java 590f9a2 > src/master/http.cpp 628112b > src/master/master.cpp 6ae8aef > src/python/native/mesos_executor_driver_impl.cpp 6e8fb9c > src/python/native/mesos_scheduler_driver_impl.cpp 4b142ce > src/python/native/module.hpp add021c > src/python/native/module.cpp 59d74a4 > src/python/native/proxy_executor.hpp aabb6c4 > src/python/native/proxy_scheduler.hpp a348cbb > src/sched/sched.cpp 43d9717 > src/slave/slave.hpp b7bc45a > src/tests/exception_tests.cpp 11214c2 > src/tests/fault_tolerance_tests.cpp 130218d > src/tests/master_tests.cpp 256945f > src/tests/resource_offers_tests.cpp 303a933 > src/tests/utils.hpp 8c038ce > src/webui/master/framework.tpl 9e384c1 > > Diff: https://reviews.apache.org/r/4448/diff > > > Testing > ------- > > make check && make hadoop > > > Thanks, > > Benjamin > >
