----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4434/#review6247 -----------------------------------------------------------
I do want to get this committed, but when I was looking a little closer there are a few cleanups to make first. src/common/logging.cpp <https://reviews.apache.org/r/4434/#comment13503> This all becomes: return conf.get("log_dir", ""); Also, is it okay to return an empty log dir!? src/configurator/configurator.hpp <https://reviews.apache.org/r/4434/#comment13579> As long as you're in this file, please kill these white spaces. src/configurator/configurator.hpp <https://reviews.apache.org/r/4434/#comment13580> And here. src/launcher/launcher.cpp <https://reviews.apache.org/r/4434/#comment13504> s/frameworksHome/configuration option 'frameworks_home' src/launcher/launcher.cpp <https://reviews.apache.org/r/4434/#comment13581> Not your bug, but the '\' should not be necessary. Please kill them. Also, s/MESOS_FRAMEWORKS_HOME/the configuration option 'frameworks_home'. src/slave/slave.cpp <https://reviews.apache.org/r/4434/#comment13582> This all becomes: string workDir = conf.get("work_dir", "work"); src/slave/webui.cpp <https://reviews.apache.org/r/4434/#comment13506> Same as above. src/tests/configurator_tests.cpp <https://reviews.apache.org/r/4434/#comment13584> Kill whitespace. src/tests/configurator_tests.cpp <https://reviews.apache.org/r/4434/#comment13509> Remove extra spaces. - Benjamin On 2012-03-21 19:02:07, Charles Reiss wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/4434/ > ----------------------------------------------------------- > > (Updated 2012-03-21 19:02:07) > > > Review request for mesos and Benjamin Hindman. > > > Summary > ------- > > Removes most remaining uses of MESOS_HOME from the tree. > > Includes updates to the deploy scripts, but does not fix the deploy scripts > (since mesos-getconf still won't exist). > > After this patch, the remaining uses of MESOS_HOME I'm aware of are in the > EC2 scripts. > > > This addresses bug MESOS-85. > https://issues.apache.org/jira/browse/MESOS-85 > > > Diffs > ----- > > src/tests/external_tests.cpp 21fa705 > src/slave/slave.cpp 9332caa > src/slave/webui.cpp 9f45442 > src/tests/configurator_tests.cpp 662e01f > src/sched/sched.cpp 16770a1 > src/slave/lxc_isolation_module.cpp 8c25dd4 > src/slave/main.cpp ac780c4 > src/slave/process_based_isolation_module.cpp e0f3ee8 > src/master/main.cpp a8fadc9 > src/mesos/main.cpp bbdb981 > src/launcher/main.cpp 5c55ace > src/local/main.cpp d4b68a9 > src/launcher/launcher.cpp 98a4847 > src/launcher/launcher.hpp 221094f > src/deploy/mesos-env.sh 9f93a41 > src/deploy/mesos-daemon 2e75d04 > src/configurator/configurator.hpp a3a104f > src/configurator/configurator.cpp 2666e50 > src/common/logging.cpp 9e346f2 > > Diff: https://reviews.apache.org/r/4434/diff > > > Testing > ------- > > make check > > > Thanks, > > Charles > >
