> On 2012-03-21 18:26:09, Benjamin Hindman wrote: > > include/mesos/mesos.proto, line 276 > > <https://reviews.apache.org/r/4433/diff/1/?file=94189#file94189line276> > > > > How about something like: > > // Initial state, can not be transitioned to (via status updates).
fixed > On 2012-03-21 18:26:09, Benjamin Hindman wrote: > > include/mesos/mesos.proto, lines 277-282 > > <https://reviews.apache.org/r/4433/diff/1/?file=94189#file94189line277> > > > > Let's actually not change these numbers. Making TASK_STAGING be 6 is > > just fine. done > On 2012-03-21 18:26:09, Benjamin Hindman wrote: > > src/exec/exec.cpp, line 230 > > <https://reviews.apache.org/r/4433/diff/1/?file=94190#file94190line230> > > > > What about aborting the framework instead? done > On 2012-03-21 18:26:09, Benjamin Hindman wrote: > > src/master/master.cpp, lines 300-301 > > <https://reviews.apache.org/r/4433/diff/1/?file=94192#file94192line300> > > > > You can kill these two checks if you'd prefer. killed > On 2012-03-21 18:26:09, Benjamin Hindman wrote: > > src/slave/slave.cpp, lines 197-198 > > <https://reviews.apache.org/r/4433/diff/1/?file=94195#file94195line197> > > > > Can kill these too (rather than making the complicated because of the > > weird number ordering). killed - Vinod ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4433/#review6176 ----------------------------------------------------------- On 2012-03-21 17:43:24, Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/4433/ > ----------------------------------------------------------- > > (Updated 2012-03-21 17:43:24) > > > Review request for mesos, Benjamin Hindman and John Sirois. > > > Summary > ------- > > To avoid ambiguity between the TASK_STARTING state that could be sent by the > executors, added a new TASK_STAGING state. > > This state should only be used by mesos core and a status update with this > state is explicitly disallowed from executors. > > > Diffs > ----- > > include/mesos/mesos.proto 478f561 > src/exec/exec.cpp 53f7e54 > src/master/http.cpp 628112b > src/master/master.cpp 6ae8aef > src/slave/http.cpp e259642 > src/slave/slave.hpp b7bc45a > src/slave/slave.cpp 9332caa > > Diff: https://reviews.apache.org/r/4433/diff > > > Testing > ------- > > make check > > > Thanks, > > Vinod > >
