> On 2012-03-24 20:44:31, Benjamin Hindman wrote:
> > src/examples/java/test-exception-framework.in, line 9
> > <https://reviews.apache.org/r/4439/diff/1/?file=94333#file94333line9>
> >
> >     Is using the '-' semantics standard Bourne Shell or does this require 
> > BASH?

It's standard. 
http://pubs.opengroup.org/onlinepubs/9699919799/utilities/V3_chap02.html#tag_18_06_02


> On 2012-03-24 20:44:31, Benjamin Hindman wrote:
> > src/examples/java/test-exception-framework.in, line 37
> > <https://reviews.apache.org/r/4439/diff/1/?file=94333#file94333line37>
> >
> >     Here and everywhere else: s/$JAVA/${JAVA}

Done.


- Charles


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4439/#review6328
-----------------------------------------------------------


On 2012-03-24 21:02:30, Charles Reiss wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4439/
> -----------------------------------------------------------
> 
> (Updated 2012-03-24 21:02:30)
> 
> 
> Review request for mesos and Benjamin Hindman.
> 
> 
> Summary
> -------
> 
> Use JAVA_HOME to run java for the Java example frameworks. This should allow 
> tests to pass if JAVA_HOME specified at configure-time is incompatible with 
> the java on the path. (e.g. $JAVA_HOME/bin/javac is Java 7, but the 'java' on 
> the PATH is Java 6).
> 
> 
> This addresses bug MESOS-87.
>     https://issues.apache.org/jira/browse/MESOS-87
> 
> 
> Diffs
> -----
> 
>   src/examples/java/test-exception-framework.in 415d355 
>   src/examples/java/test-executor.in 4e8daf6 
>   src/examples/java/test-framework.in 2c12953 
>   src/examples/java/test-multiple-executors-framework.in 04c0d5b 
> 
> Diff: https://reviews.apache.org/r/4439/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Charles
> 
>

Reply via email to